Add script for remove ledger #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anton.denishchenko <anton.denishchenko@evernym.com>
adenishchenko
requested review from
lampkin-diet,
ashcherbakov,
skhoroshavin and
Toktar
as code owners
|
Can one of the admins verify this patch? |
Signed-off-by: anton.denishchenko <anton.denishchenko@evernym.com>
Signed-off-by: anton.denishchenko <anton.denishchenko@evernym.com>
|
(ci) test this please |
WadeBarnes
reviewed
Feb 11, 2021
WadeBarnes
requested changes
Feb 11, 2021
There was a problem hiding this comment.
I'd highly recommend the script provide some feedback to the user and wait for confirmation.
It should clearly indicate it's about to delete a ledger, which ledger it's about to delete, describe the consequences, and then wait for confirmation from the user.
Some help text for the script would also be useful for those that are curious about what the script does, but don't want to read and fully understand the code.
|
@WadeBarnes Great ideas |
Signed-off-by: anton.denishchenko <anton.denishchenko@evernym.com>
WadeBarnes
requested changes
Feb 12, 2021
Signed-off-by: anton.denishchenko <anton.denishchenko@evernym.com>
askolesov
reviewed
Feb 12, 2021
WadeBarnes
requested changes
Feb 12, 2021
adenishchenko
force-pushed
the
migration_mainnet
branch
from
eb429c5 to
dfe641b
Compare
|
(ic) test this please. |
WadeBarnes
requested changes
Feb 12, 2021
There was a problem hiding this comment.
Code is failing static analysis; https://build.sovrin.org/job/indy-node/job/indy-node-verify-x86_64/2836/execution/node/18/log/
Signed-off-by: anton.denishchenko <anton.denishchenko@evernym.com>
askolesov
approved these changes
Feb 15, 2021
|
(ci) test this please |
|
(ci) ok to test |
|
@WadeBarnes It seems that all comments were processed. Could you review this again, please? |
WadeBarnes
approved these changes
Feb 15, 2021
|
@Toktar, @skhoroshavin, We just need approval from a code owner. |
Toktar
approved these changes
Feb 16, 2021
Toktar
added a commit
to Toktar/indy-node
that referenced
this pull request
Mar 2, 2021
Add script for remove ledger Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: behalf
Toktar
added a commit
to Toktar/indy-node
that referenced
this pull request
Mar 2, 2021
Add script for remove ledger Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: behalf Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable Signed-off-by: toktar <renata.toktar@dsr-corporation.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: master-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anton.denishchenko anton.denishchenko@evernym.com