Fixes wrong max slices in GHA

[pSchlarb]

Signed-off-by: pSchlarb p.schlarb@esatus.com

[sovbot]

Can one of the admins verify this patch?

[udosson]

@pSchlarb thanks for the PR. Could you please provide some context and justify the proposed changes?

[pSchlarb]

Yes, shimizut in the Rocketchat mentioned that the tests run by the GHA are only executing 11 of 22 slices per module.
It seems that the variable used strategy.job-total is the sum of all slices across all modules.
So to correctly test all slices with the runner these changes are neccessary.

[WadeBarnes]

I don't really like the idea of hard coding the number of slices. The original intent was to be able to update this section and have the test runs automatically adjust accordingly. Obviously strategy.job-total is the number of modules * the number of slices. We want it to just be the number of slices. The question is how do we get that value without hard coding it.

      matrix:
        module: [indy_node, indy_common]
        slice: [1, 2, 3, 4 ,5, 6, 7, 8, 9, 10, 11]

[WadeBarnes]

There does not seem to be a way to get the count of items included in the elements of a matrix.

What if we added a slice_count environment variable and had it set to the total number of slices, and documented it has to match the number of items contained in strategy.matrix.slice. It's still a bit of a hack, but better then having to change the value in multiple places is/when the number of items contained in strategy.matrix.slice is changed.

[pSchlarb]

I am fine with that but i would call it SLICE_TOTAL_SLICES.

[WadeBarnes]

(ci) test this please