-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release Workflow #1590
New Release Workflow #1590
Conversation
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
building/publishing on .py changes Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
Can one of the admins verify this patch? |
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small suggestions. I'm also going to test on my fork.
@pSchlarb, The following workflows have a very similar set of jobs, Do you think it's worth the extra effort at this point or should we mark it as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into some dependency issues with ./bump_version.sh
. Needed to install a few more minimal dependencies for it to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the workflow attempting to publish packages when it's running in someone's fork, since it will always fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to protect against publishing in forks here too.
The Problem with that idea is that Github doesn't allow subsequent workflow calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a line in one of the workflows was inadvertently duplicated.
if: needs.release-infos.outputs.isVersionBump == 'true' | ||
if: needs.release-infos.outputs.isVersionBump == 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate line. I think that was meant to be something like if: needs.release-infos.outputs.isVersionBump == 'true' && needs.release-infos.outputs.publish == 'true'
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
hyperledger/indy-shared-gha#4 needs to be merged first for this PR to work.