Issue #210 InvalidClientTaaAcceptanceError time too precise error if container timezone is not UTC #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Simpson <RobS.git9@MailScreen.com>
Signed-off-by: Rob Simpson <RobS.bullethell9@MailScreen.com>
added 2 commits
August 21, 2023 13:55
Signed-off-by: Rob Simpson <RobS.bullethell9@MailScreen.com>
Signed-off-by: Rob Simpson <RobS.bullethell9@MailScreen.com>
wrappers/python/indy_vdr/ledger.py
Outdated
| @@ -760,7 +760,9 @@ def prepare_txn_author_agreement_acceptance( | |||
| if not accepted_time: | |||
| # rough timestamp | |||
| accepted_time = int( | |||
| datetime.combine(date.today(), datetime.min.time()).timestamp() | |||
| datetime.combine( | |||
| date.today(), datetime.min.time(), datetime.timezone.utc | |||
There was a problem hiding this comment.
Suggested change
| date.today(), datetime.min.time(), datetime.timezone.utc | |
| date.today(), datetime.min.time(), timezone.utc |
Signed-off-by: Robert Simpson <RobS.git9@MailScreen.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds timezone.utc to datetime.combine to ensure time will be midnight in UTC regardless of the default timezone