Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release dev under alpha and fix windows install #230

Conversation

berendsliedrecht
Copy link
Contributor

TimoGlastra
TimoGlastra previously approved these changes Oct 27, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Berend Sliedrecht <blu3beri@proton.me>
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the non-js dev versions. That way we know all dev versions are having the same features / capabilities etc..

@berendsliedrecht
Copy link
Contributor Author

Please also update the non-js dev versions. That way we know all dev versions are having the same features / capabilities etc..

I thought from the beginning we said that version sync was not smart / not feasible, which I still agree with. Also, incrementing versions of the Python (and possibly rust lib) won't change anything in feature parity and they are on version v0.4.0. Maybe I misunderstood your comment, but for me all wrappers / native libs versions live separately and should not be related to each other (especially for dev).

@TimoGlastra
Copy link
Member

thought from the beginning we said that version sync was not smart / not feasible, which I still agree with

This is mainly for the specific version (0.1.0/0.2.0). But once we are working with a .dev version in the rust library, we do get benefit from at least keeping the dev versions in sync. It's just weird to have 0.2.0-dev.4 depends on 0.2.0-dev.2 native library.

So until we're out of dev, I think we should keep the dev- in sync

@TimoGlastra
Copy link
Member

Oh wait I understand now. The Indy VDR native library is not in dev. Then it's fine yes 👍

My comment was mainly about if the native library has a dev version. But that's currently only the case for AnonCreds

@berendsliedrecht berendsliedrecht merged commit df67899 into hyperledger:main Oct 27, 2023
25 checks passed
@berendsliedrecht berendsliedrecht deleted the release-under-alpha-and-fix-windows branch October 27, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants