Loosen time dependency patch version constraint #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
|
There hasn't been a new release of the time crate past 0.3.36 so this doesn't have any effect right now. It's possible that a new release would increase the minimum Rust version past what we currently need for the Android build, but that's true of the other dependencies as well so I don't think it hurts to loosen this up for now. |
andrewwhitehead
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were locked into time
=0.3.20: #166Recently it was updated to
=0.3.36due to issues with rust 1.80 and <0.3.36 versions of time.However just as a crate cleanliness, it would be nice to only pin the version to 0.3.36 if we absolutely have to, dep conflicts may arise for consumers of the indy-vdr in the future as a result etc
FYI @andrewwhitehead : RE your original decision to lock the time version, is it still necessary?