Feature/python wrapper with multiple ledger support #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
domwoe
commented
Mar 25, 2022
wrappers/python/indy_vdr/resolver.py
Outdated
Comment on lines
68
to
100
| # Handle legacy case, where diddocContent is not present and we want to check for | ||
| # associated ATTRIB endpoints. We can't handle in this in libindy_vdr directly. | ||
| if not diddoc_content: | ||
| unqualified_did = reply_data["dest"] | ||
| req = build_get_attrib_request(None, unqualified_did, "endpoint", None, None) | ||
| res = await pool.submit_request(req) | ||
| data = res.get("data", None) | ||
| if data: | ||
| data = json.loads(data) | ||
| endpoints = data.get("endpoint", None) | ||
|
|
||
| if endpoints: | ||
| services = [] | ||
| for (service_type, service_endpoint) in endpoints.items(): | ||
| if service_type == "endpoint": | ||
|
|
||
| services.append({ | ||
| "id": f"did:indy:{namespace}:{unqualified_did}#did-communication", | ||
| "type": "did-communication", | ||
| "recipientKeys": [f"did:indy:{namespace}:{unqualified_did}#verkey"] , | ||
| "routingKeys": [], | ||
| "priority": 0 | ||
| }) | ||
|
|
||
| else: | ||
|
|
||
| services.append({ | ||
| "id": f"did:indy:{namespace}:{unqualified_did}#{service_type}", | ||
| "type": service_type, | ||
| "serviceEndpoint": service_endpoint | ||
|
|
||
| }) | ||
| result["didDocument"]["services"] = services; |
There was a problem hiding this comment.
After countless hours trying to handle fetching the legacy endpoint (ATTRIB tx) on the rust side before crossing the ffi bridge I resigned.
I don't like it but I have added this code to the python wrapper to fetch the ATTRIB data and attach it to the did document.
If the PoolResolver is used from Rust projects (e.g. the proxy server) then this custom code is not necessary, but handled internally.
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
domwoe
force-pushed
the
feature/python-with-multiple-ledger-support
branch
from
d518c99 to
9906f32
Compare
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
…rate_did dependeny Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Woerner <dom.woe@gmail.com>
Signed-off-by: Dominic Woerner <dom.woe@gmail.com>
Signed-off-by: Dominic Woerner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
Get attrib with optional seq_no and timestamp and self-cert version tests
Signed-off-by: Dominic Wörner <dom.woe@gmail.com>
andrewwhitehead
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added python wrapper for multi-ledger did resolution
Exposes three simple ways to set up a resolver: