Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 31, 2025

This PR updates the default Rust toolchain version from 1.85.0 to 1.86.0 in the GitHub Action workflow setup while maintaining backward compatibility for existing CI workflows.

Changes Made

  • Updated the default value for the rust-toolchain input parameter from "1.85.0" to "1.86.0"
  • Updated the description text to reflect the new default version
  • Added installation of Rust 1.85.0 toolchain alongside existing 1.81.0 for backward compatibility

Backward Compatibility

The action now installs multiple Rust toolchain versions to ensure compatibility with older CI workflows:

  • 1.86.0 - New default toolchain for new workflows
  • 1.85.0 - Previous default, maintained for existing workflows that may depend on it
  • 1.81.0 - Older version maintained for legacy compatibility

What's Not Changed

  • All other configuration and setup steps remain unchanged
  • YAML syntax and structure validated to ensure correctness
  • Users can still override the default version by explicitly setting the rust-toolchain parameter

This ensures a smooth transition where existing workflows continue to work without modification while new workflows benefit from the latest Rust toolchain.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update the workflow so it uses rust version 1.86 Update Rust toolchain from 1.85.0 to 1.86.0 Jul 31, 2025
Copilot AI requested a review from simongdavies July 31, 2025 15:17
@simongdavies simongdavies marked this pull request as ready for review July 31, 2025 15:25
@simongdavies simongdavies force-pushed the copilot/fix-9c02d6b8-11b1-4e0d-a324-a80250d12683 branch from a82f05c to 8bbec14 Compare July 31, 2025 16:12
@simongdavies simongdavies force-pushed the copilot/fix-9c02d6b8-11b1-4e0d-a324-a80250d12683 branch from 8bbec14 to fb1d421 Compare July 31, 2025 16:13
@marosset
Copy link
Contributor

@copilot can you update this to also install rust 1.85 toolchain to maintain compatibility with older CI workflows?

Example: we still install the 1.81.0 toolchain here:

# We do this in case there is toolchain skew between repos
- name: Install older rust toolchain(s)
if: ${{ (runner.os == 'Linux') }}
run: |
rustup toolchain install 1.81.0
shell: bash

Copy link
Contributor Author

Copilot AI commented Jul 31, 2025

@copilot can you update this to also install rust 1.85 toolchain to maintain compatibility with older CI workflows?

Example: we still install the 1.81.0 toolchain here: https://github.com/hyperligh...

Added installation of Rust 1.85.0 toolchain alongside the existing 1.81.0 installation for both Linux and Windows platforms to maintain backward compatibility with older CI workflows. This ensures any workflows depending on 1.85.0 will continue to work after the default is updated to 1.86.0. (5f0cd30)

Copilot AI changed the title Update Rust toolchain from 1.85.0 to 1.86.0 Update Rust toolchain from 1.85.0 to 1.86.0 with backward compatibility Jul 31, 2025
Copilot AI requested a review from marosset July 31, 2025 17:52
@marosset
Copy link
Contributor

Let's merge https://github.com/hyperlight-dev/dev-images/pull/35 and build new images, then get this in

Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset marosset force-pushed the copilot/fix-9c02d6b8-11b1-4e0d-a324-a80250d12683 branch from 5f0cd30 to bf09d19 Compare August 7, 2025 20:50
@marosset marosset merged commit c8fd925 into main Aug 7, 2025
1 check passed
@marosset marosset deleted the copilot/fix-9c02d6b8-11b1-4e0d-a324-a80250d12683 branch August 7, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants