fix(hyperlight-component-util): Fix emit_hl_unmarshal_value to return a tuple for boolean values
#437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that setting an execution timeout of 0 disables execution timeouts entirely. This is temporary, as we intend to remove the wall-clock timeout feature from Hyperlight entirely in the near future. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This is useful to allow host-side code to work on both core Hyperlight sandboxes and wrapped sandboxes like Hyperlight Wasm. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This is useful to allow host-side code to work on both core Hyperlight sandboxes and wrapped sandboxes like Hyperlight Wasm. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This commit adds a general implementation of WebAssembly Component Model type elaboration, closely derived from the formal specification. It also adds a number of functions which can generate Rust binding code from appropriately-structured (roughly: WIT-like) component types. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This adds a proc-macro crate that exposes the bindings code generation from hyperlight_component_util as a macro suitable for using WIT to define a hyperlight host<->guest interface. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
… a tuple for boolean values This updates the emit_hl_unmarshal_value function to return a tuple containing the boolean value and a constant 1, which fixes the following build error if a function that has a bool as its argument is called: ``` error[E0610]: `bool` is a primitive type and therefore doesn't have fields ``` Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Mossaka
changed the title
emit_hl_unmarshal_value to return a tuple for boolean values
syntactically
force-pushed
the
hyperlight-component-macro
branch
10 times, most recently
from
6c48fd8 to
3143032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the emit_hl_unmarshal_value function to return a tuple
containing the boolean value and a constant 1, which fixes the following
build error if a function that has a bool as its argument is called:
Signed-off-by: Jiaxiao (mossaka) Zhou duibao55328@gmail.com