Fixes a race condition in killing Sandboxes #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
simongdavies
force-pushed
the
fix-race-1
branch
2 times, most recently
from
ad6647c to
96a6fce
Compare
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-race-1
branch
from
96a6fce to
d200c7c
Compare
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
…sted by us Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
reviewed
Oct 17, 2025
| /// retrying until either: | ||
| /// - The signal is successfully delivered (VCPU transitions from running to not running) | ||
| /// - The VCPU stops running for another reason (e.g., call completes normally) | ||
| /// - No call is active (call_active=false) |
There was a problem hiding this comment.
Does it block? I thought it would just return false?
jsturtevant
reviewed
Oct 18, 2025
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
reviewed
Oct 18, 2025
| // The virtualization stack can use this function to return the control | ||
| // of a virtual processor back to the virtualization stack in case it | ||
| // needs to change the state of a VM or to inject an event into the processor | ||
| debug!("Internal cancellation detected, returning Retry error"); |
There was a problem hiding this comment.
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-race-1
branch
from
4e211f2 to
4de305a
Compare
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
ludfjig
reviewed
Oct 21, 2025
| /// This is acceptable because the generation tracking provides an additional | ||
| /// safety layer. Even if a stale kill somehow stamped cancel_requested, the | ||
| /// generation mismatch would cause it to be ignored. | ||
| call_active: AtomicBool, |
There was a problem hiding this comment.
I think this flag is redundant. We will already not send any signals when calling kill if the vcpu is not running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition where a sandbox kill arrives after a sandbox has successfully exited causing the subsequent run to fail.
There is a breaking change in this PR, previously if kill was called on an
InterruptHandlebefore or while a guest call was not in progress the next guest call made on theSandboxwould be cancelled , now this scenario is a no-op. kill only takes effect if there is a guest call running.