-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: allow specifying multiple transforms #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying multiple transforms #66
Conversation
maybe would be nicer if the interface would be `-t t1 -t t2 -t t3` instead of current `-t t1,t2,t3` (you could separate into multiple lines and keep it cleaner), but don't know how to do that so this works just fine. Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
Hey @kiprasmel, Commanderjs actually has a way to support https://github.com/tj/commander.js/#variadic-option Would you like to have a crack at that? |
hey @danieldelcore!
I haven't seen that. Looked thru - actually it looks a little too magical for me:D I think people are not really used to it, and myself I'd expect only the first argument to be picked up after the option I'd love if we could make the |
Not as far as I know, commander doesn't seem to support it anything like that. Unless it comes by default, but if that was the case i'd probably already work ahah (might be worth double-checking though). Do you know of any CLIs with this style of API? Would be interesting to see how it's done elsewhere.
Commander is quite nice in that it encapsulates a lot of the established CLI conventions, things like variatic options are often used in common CLIs like git, example: At this point, I prefer to go with either |
yeah i thought that the -t t1 -t t2 would be more common tbh, but not sure. the git cherry-pick example - that's true, but the variadic options are for the i thus think perhaps the current one |
hey @danieldelcore! you think we could merge this? we'd like to move away from having our codemods in the fork and instead utilize #58, and we kinda depend on this. |
No worries, i have some time today! Thanks for letting me know again 😄 |
Hey @kiprasmel, I wasn't able to push to your remote so I've recreated this Pr with a changeset here: #80 Merging it now, thanks for your patience 😄 |
maybe would be nicer if the interface would be
-t t1 -t t2 -t t3
instead of current
-t t1,t2,t3
(you could separate into multiple linesand keep it cleaner), but don't know how to do that so this works just fine.