Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable CompactL0OnClose by default #1586

Merged
merged 3 commits into from
Nov 10, 2020
Merged

fix: Disable CompactL0OnClose by default #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed31b65
Disable CompactL0OnClose by default
ajeetdsouza Nov 6, 2020
5ccaf9d
Merge branch 'master' into ajeetdsouza/compact
ajeetdsouza Nov 9, 2020
48e89ca
Enable CompactL0OnClose in certain tests
ajeetdsouza Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ func TestForceCompactL0(t *testing.T) {
require.NoError(t, err)
defer removeDir(dir)

opts := getTestOptions(dir)
// This test relies on CompactL0OnClose
opts := getTestOptions(dir).WithCompactL0OnClose(true)
opts.ValueLogFileSize = 15 << 20
opts.managedTxns = true
db, err := Open(opts)
Expand Down
3 changes: 2 additions & 1 deletion merge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ func TestGetMergeOperator(t *testing.T) {
require.NoError(t, err)
defer removeDir(dir)

opts := getTestOptions(dir)
// This test relies on CompactL0OnClose
opts := getTestOptions(dir).WithCompactL0OnClose(true)
db, err := Open(opts)
require.NoError(t, err)
mergeKey := []byte("foo")
Expand Down
7 changes: 3 additions & 4 deletions options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func DefaultOptions(path string) Options {
BlockSize: 4 * 1024,
SyncWrites: false,
NumVersionsToKeep: 1,
CompactL0OnClose: true,
CompactL0OnClose: false,
VerifyValueChecksum: false,
Compression: options.Snappy,
BlockCacheSize: 256 << 20,
Expand Down Expand Up @@ -425,10 +425,9 @@ func (opt Options) WithNumCompactors(val int) Options {
}

// WithCompactL0OnClose determines whether Level 0 should be compacted before closing the DB. This
// ensures that both reads and writes are efficient when the DB is opened later. CompactL0OnClose
// is set to true if KeepL0InMemory is set to true.
// ensures that both reads and writes are efficient when the DB is opened later.
//
// The default value of CompactL0OnClose is true.
// The default value of CompactL0OnClose is false.
func (opt Options) WithCompactL0OnClose(val bool) Options {
opt.CompactL0OnClose = val
return opt
Expand Down