Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make skiplist grow #1695

Merged
merged 6 commits into from
Apr 26, 2021
Merged

Make skiplist grow #1695

merged 6 commits into from
Apr 26, 2021

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Apr 23, 2021 •
edited by ahsanbarkati
Loading

Sorted write benchmark:

pkg: github.com/dgraph-io/badger/v3/skl
cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
BenchmarkSortedWrites
BenchmarkSortedWrites/builder
BenchmarkSortedWrites/builder-8         	11266122	       107.3 ns/op
BenchmarkSortedWrites/skiplist
BenchmarkSortedWrites/skiplist-8        	 2378619	       548.1 ns/op
BenchmarkSortedWrites/buffer
BenchmarkSortedWrites/buffer-8          	11134172	       107.0 ns/op

Benchmarks on this branch:

pkg: github.com/dgraph-io/badger/v3/skl
cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
BenchmarkReadWrite
BenchmarkReadWrite/frac_0
BenchmarkReadWrite/frac_0-8         	 3270193	       497.5 ns/op
BenchmarkReadWrite/frac_1
BenchmarkReadWrite/frac_1-8         	 3122666	       474.7 ns/op
BenchmarkReadWrite/frac_2
BenchmarkReadWrite/frac_2-8         	 3215018	       454.6 ns/op
BenchmarkReadWrite/frac_3
BenchmarkReadWrite/frac_3-8         	 3497979	       431.5 ns/op
BenchmarkReadWrite/frac_4
BenchmarkReadWrite/frac_4-8         	 3960559	       427.1 ns/op
BenchmarkReadWrite/frac_5
BenchmarkReadWrite/frac_5-8         	 4304965	       396.9 ns/op
BenchmarkReadWrite/frac_6
BenchmarkReadWrite/frac_6-8         	 4831591	       377.2 ns/op
BenchmarkReadWrite/frac_7
BenchmarkReadWrite/frac_7-8         	 5106373	       342.2 ns/op
BenchmarkReadWrite/frac_8
BenchmarkReadWrite/frac_8-8         	 6648694	       375.4 ns/op
BenchmarkReadWrite/frac_9
BenchmarkReadWrite/frac_9-8         	 5147310	       344.5 ns/op
BenchmarkReadWrite/frac_10
BenchmarkReadWrite/frac_10-8        	46336015	        23.38 ns/op

Benchmarks on master

pkg: github.com/dgraph-io/badger/v3/skl
cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
BenchmarkReadWrite
BenchmarkReadWrite/frac_0
BenchmarkReadWrite/frac_0-8         	 3398978	       490.5 ns/op
BenchmarkReadWrite/frac_1
BenchmarkReadWrite/frac_1-8         	 3551136	       463.2 ns/op
BenchmarkReadWrite/frac_2
BenchmarkReadWrite/frac_2-8         	 3783042	       453.8 ns/op
BenchmarkReadWrite/frac_3
BenchmarkReadWrite/frac_3-8         	 4080016	       402.6 ns/op
BenchmarkReadWrite/frac_4
BenchmarkReadWrite/frac_4-8         	 4378216	       407.5 ns/op
BenchmarkReadWrite/frac_5
BenchmarkReadWrite/frac_5-8         	 4904280	       364.6 ns/op
BenchmarkReadWrite/frac_6
BenchmarkReadWrite/frac_6-8         	 5326681	       362.7 ns/op
BenchmarkReadWrite/frac_7
BenchmarkReadWrite/frac_7-8         	 6351204	       327.8 ns/op
BenchmarkReadWrite/frac_8
BenchmarkReadWrite/frac_8-8         	 7129779	       338.8 ns/op
BenchmarkReadWrite/frac_9
BenchmarkReadWrite/frac_9-8         	 5378049	       326.9 ns/op
BenchmarkReadWrite/frac_10
BenchmarkReadWrite/frac_10-8        	47002140	        23.72 ns/op

This change is Reviewable

@ahsanbarkati ahsanbarkati marked this pull request as ready for review April 26, 2021 15:56
@ahsanbarkati ahsanbarkati merged commit 84267c4 into master Apr 26, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/skl-builder-grow branch April 26, 2021 16:10
fredcarle pushed a commit to fredcarle/badger that referenced this pull request Aug 1, 2023
@manishrjain @ahsanbarkati @fredcarle
Make skiplist grow (hypermodeinc#1695)
33ca02f 
This change makes the skiplist grow for the case of sorted
skiplist builder. The normal skiplist still cannot grow.
Note: The growing skiplist is not thread safe.

Co-authored-by: Ahsan Barkati <ahsanbarkati@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manishrjain @jarifibrahim @ahsanbarkati