Drop discard stats if we can't unmarshal it #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to prevent badger from starting if we can't read/unmarshal discard stats.
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
manishrjain
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
ashish-goswami
approved these changes
Jul 18, 2019
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 24, 2019
We don't want to prevent badger from starting up if we can't read/unmarshal discard stats.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Drop discard stats if we can't unmarshal it We don't want to prevent badger from starting up if we can't read/unmarshal discard stats. (cherry picked from commit c5bf7e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to prevent badger from starting if we can't read/unmarshal
discard stats.
Fixes hypermodeinc/dgraph#3669
This change is