Fix prefix bug in key iterator and allow all versions #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
manishrjain
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
The title and description of this PR does not say anything about the bug that's being fixed. That is the main focus here. The issue doesn't ask for AllVersions being set to true. I can see why that makes sense, but that's a secondary concern. Please change them before merging.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
The key iterator is supposed to iterate over all versions of the same key but the current implementation would iterate over all keys with the prefix. For example: A key iterator for "foo" would return true for "foo" and "foobar". This commit fixes the issue. This commit also sets the value of allVersions to true in the key iterator.
jarifibrahim
force-pushed
the
ibrahim/keyonlyiterator
branch
from
054aa70 to
9d4e4ec
Compare
jarifibrahim
changed the title
poonai
approved these changes
Aug 1, 2019
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 9, 2019
The key iterator is supposed to iterate over all versions of the same key but the current implementation would iterate over all keys with the given prefix. For example, A key iterator for "foo" would return true for "foo" and "foobar". This commit fixes the issue. This commit also sets the value of `allVersions` to true in the key iterator.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
The key iterator is supposed to iterate over all versions of the same key but the current implementation would iterate over all keys with the given prefix. For example, A key iterator for "foo" would return true for "foo" and "foobar". This commit fixes the issue. This commit also sets the value of `allVersions` to true in the key iterator. (cherry picked from commit a11c5e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key iterator is supposed to iterate over all versions of the same key
but the current implementation would iterate over all keys with the given prefix.
For example: A key iterator for "foo" would return true for "foo" and
"foobar". This commit fixes the issue.
This commit also sets the value of
allVersionsto true in the key iterator.Fixes #943
This change is