Fix boundaries on GC batch size #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorgorman
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@connorgorman you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Changes match the description. Should there be a test to make sure this doesn't regress?
Reviewed with ❤️ by PullRequest
jarifibrahim
approved these changes
Aug 19, 2019
|
@ashish-goswami Please review this PR. |
ashish-goswami
approved these changes
Aug 19, 2019
|
The change looks harmless. I'm merging it. |
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
In the value log rewrite, the check to determine if the commit was
going to be within transaction limits is checked only if the value
would be `>` than the max count. However, the check within the
transaction is:
```
if count >= db.opt.maxBatchCount || size >= db.opt.maxBatchSize {
return nil, ErrTxnTooBig
}
```
(cherry picked from commit 9725af7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the value log rewrite, the check to determine if the commit was going to be within transaction limits only checked if the value would be
>than the max count. However, the check within the transaction is:This change is