JSON parse issue fix for Payload response

[prashant-shahi]

Fixes #43

• Catch JSON parse exception
• Upon the exception, return the original string instead for the getData function

---

This change is 

[paulftw]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @paulftw and @prashant-shahi)

---

generated/api_pb.js, line 574 at r1 (raw file):

proto.api.Request.prototype.clearVarsMap = function() {
  this.getVarsMap().clear();
  return this;};

You aren't editing generated files, are you?

Why did this file change, when we haven't changed the generator version in package.json / yarn.lock?

---

src/types.ts, line 24 at r1 (raw file):

        }

        let res: any; // tslint:disable-line no-any

I think

try { return JSON.parse(jsonStr) } catch (err) { return jsonStr }

would be a lot easier to read (with formatting). and doesn't need extra var & tslint:disable

[prashant-shahi]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @paulftw)

---

generated/api_pb.js, line 574 at r1 (raw file):

Previously, paulftw (Paul Korzhyk) wrote…

You aren't editing generated files, are you?

Why did this file change, when we haven't changed the generator version in package.json / yarn.lock?

I didn't change this file. But I have seen it happen before as well when I run npm build:protos followed by ./generate_proto.sh

---

src/types.ts, line 24 at r1 (raw file):

Previously, paulftw (Paul Korzhyk) wrote…

I think

try { return JSON.parse(jsonStr) } catch (err) { return jsonStr }

would be a lot easier to read (with formatting). and doesn't need extra var & tslint:disable

Done.

[prashant-shahi]

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @paulftw)

---

generated/api_pb.js, line 574 at r1 (raw file):

Previously, prashant-shahi (Prashant Shahi) wrote…

I didn't change this file. But I have seen it happen before as well when I run npm build:protos followed by ./generate_proto.sh

Done.