add vector support for graphQL #9067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/testing
shivaji-kharse
force-pushed
the
shiva/graphQL
branch
2 times, most recently
from
6474add to
0dc9fcd
Compare
harshil-goel
requested changes
Apr 15, 2024
| @@ -669,6 +673,13 @@ func genDgSchema(gqlSch *ast.Schema, definitions []string, | |||
| } | |||
| } | |||
|
|
|||
| embedding := f.Directives.ForName(embeddingDirective) | |||
| if embedding != nil { | |||
| // embeddingValidation ensured GQL type is [Float] | |||
There was a problem hiding this comment.
What happens if we first have a schema with normal [Float], but then we add embedding
| if field.Type.NamedType == "String" || | ||
| field.Type.NamedType == "Int" || | ||
| field.Type.NamedType == "Int64" { | ||
| if field.Type.String() == "String!" || |
| // hnsw | ||
| // hnsw(exponent: 3) | ||
| func parseSearchOptions(searchArg string) (map[string]string, bool) { | ||
| searchArg = strings.TrimSpace(searchArg) |
| // } | ||
| func rewriteAsSimilarByEmbeddingQuery( | ||
| query schema.Query, auth *authRewriter) []*dql.GraphQuery { | ||
|
|
There was a problem hiding this comment.
can you cehck if auth works?
shivaji-kharse
force-pushed
the
shiva/graphQL
branch
2 times, most recently
from
59622a2 to
dd806c2
Compare
shivaji-kharse
force-pushed
the
shiva/graphQL
branch
from
dd806c2 to
86f5035
Compare
query/vector_graphql_test.go
Outdated
| type Project { | ||
| id: ID! | ||
| title: String! @search(by: [exact]) | ||
| title_v: [Float!] @hm_embedding @search(by: ["hnsw(metric: euclidian, exponent: 4)"]) |
| @@ -37,7 +37,7 @@ func TestDgraphMapping_WithoutDirectives(t *testing.T) { | |||
| type Author { | |||
| id: ID! | |||
|
|
|||
| name: String! @search(by: [hash, trigram]) | |||
| name: String! @search(by: ["hash", "trigram"]) | |||
There was a problem hiding this comment.
old thing should still work. We should not expect customers to change this
| Product.title : Product.title | ||
| Product.productVector : Product.productVector | ||
| dgraph.uid : uid | ||
| Product.hm_distance : val(distance) |
There was a problem hiding this comment.
hm_distance to distance
| } | ||
|
|
||
| type Project1 { |
There was a problem hiding this comment.
rename this to ProjectDotProduct, and ProjectCosine instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title format:
Topic(Area): FeatureTopicmust be one ofbuild|ci|docs|feat|fix|perf|refactor|chore|testAreamust be one ofacl|audit|backup|badger|cdc|dql|export|graphql|indexing|multi-tenancy|raft|restore|upgrade|zeroBody Format:
Description:
Fixes:
Closes:
Docs: