Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a function that translates map[string]interface{} to ast.Value #1

Merged
merged 1 commit into from
Dec 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gqlparser.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,7 @@ func MustLoadQuery(schema *ast.Schema, str string) *ast.QueryDocument {
}
return q
}

func LoadVariables(schema *ast.Schema, op *ast.OperationDefinition, vars map[string]interface{}) (map[string]*ast.Value, *gqlerror.Error) {
return validator.Variables(schema, op, vars)
}
227 changes: 227 additions & 0 deletions validator/vars.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package validator

import (
"reflect"
"strconv"
"strings"

"fmt"
Expand All @@ -12,6 +13,62 @@ import (

var UnexpectedType = fmt.Errorf("Unexpected Type")

func Variables(schema *ast.Schema, op *ast.OperationDefinition, variables map[string]interface{}) (map[string]*ast.Value, *gqlerror.Error) {
coercedVars := map[string]*ast.Value{}

validator := varValidator{
path: []interface{}{"variable"},
schema: schema,
}

for _, v := range op.VariableDefinitions {
validator.path = append(validator.path, v.Variable)

if !v.Definition.IsInputType() {
return nil, gqlerror.ErrorPathf(validator.path, "must an input type")
}

val, hasValue := variables[v.Variable]
if !hasValue {
if v.DefaultValue != nil {
var err error
val, err = v.DefaultValue.Value(nil)
if err != nil {
return nil, gqlerror.WrapPath(validator.path, err)
}
hasValue = true
} else if v.Type.NonNull {
return nil, gqlerror.ErrorPathf(validator.path, "must be defined")
}
}

if hasValue {
if val == nil {
if v.Type.NonNull {
return nil, gqlerror.ErrorPathf(validator.path, "cannot be null")
}
coercedVars[v.Variable] = nil
} else {
rv := reflect.ValueOf(val)
if rv.Kind() == reflect.Ptr || rv.Kind() == reflect.Interface {
rv = rv.Elem()
}

vars, err := validator.getVars(v.Type, rv)
if err != nil {
return nil, err
}

coercedVars[v.Variable] = vars
}
}

validator.path = validator.path[0 : len(validator.path)-1]
}

return coercedVars, nil
}

// VariableValues coerces and validates variable values
func VariableValues(schema *ast.Schema, op *ast.OperationDefinition, variables map[string]interface{}) (map[string]interface{}, *gqlerror.Error) {
coercedVars := map[string]interface{}{}
Expand Down Expand Up @@ -73,6 +130,176 @@ type varValidator struct {
schema *ast.Schema
}

func (v *varValidator) getVars(typ *ast.Type, val reflect.Value) (*ast.Value, *gqlerror.Error) {
currentPath := v.path
resetPath := func() {
v.path = currentPath
}
defer resetPath()

value := &ast.Value{
Raw: val.String(),
Children: make(ast.ChildValueList, 0, 0),
}

if typ.Elem != nil {
if val.Kind() != reflect.Slice {
return nil, gqlerror.ErrorPathf(v.path, "must be an array")
}

value.Kind = ast.ListValue

for i := 0; i < val.Len(); i++ {
resetPath()
v.path = append(v.path, i)
field := val.Index(i)

if field.Kind() == reflect.Ptr || field.Kind() == reflect.Interface {
if typ.Elem.NonNull && field.IsNil() {
return nil, gqlerror.ErrorPathf(v.path, "cannot be null")
}
field = field.Elem()
}

vars, err := v.getVars(typ.Elem, field)
if err != nil {
return nil, err
}

value.Children = append(value.Children, &ast.ChildValue{
Name: strconv.Itoa(i),
Value: vars,
})

// typ.Elem is of type [typ], so it doesn't exist in v.schema.Types
//TODO find Definition from typ.Elem instead
value.Definition = vars.Definition
}

return value, nil
}

if !typ.NonNull && !val.IsValid() {
// If the type is not null and we got a invalid value namely null/nil, then it's valid
return nil, nil
}
def := v.schema.Types[typ.NamedType]
if def == nil {
panic(fmt.Errorf("missing def for %s", typ.NamedType))
}
value.Definition = def
value.Raw = val.String()

switch def.Kind {
case ast.Enum:
kind := val.Type().Kind()
value.Kind = ast.EnumValue
if kind != reflect.Int && kind != reflect.Int32 && kind != reflect.Int64 && kind != reflect.String {
return nil, gqlerror.ErrorPathf(v.path, "enums must be ints or strings")
}
isValidEnum := false
for _, enumVal := range def.EnumValues {
if strings.EqualFold(val.String(), enumVal.Name) {
isValidEnum = true
}
}
if !isValidEnum {
return nil, gqlerror.ErrorPathf(v.path, "%s is not a valid %s", val.String(), def.Name)
}
return value, nil
case ast.Scalar:
kind := val.Type().Kind()
switch typ.NamedType {
case "Int":
if kind == reflect.String || kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 {
value.Kind = ast.IntValue
return value, nil
}
case "Float":
if kind == reflect.String || kind == reflect.Float32 || kind == reflect.Float64 || kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 {
value.Kind = ast.FloatValue
return value, nil
}
case "String":
if kind == reflect.String {
value.Kind = ast.StringValue
return value, nil
}

case "Boolean":
if kind == reflect.Bool {
value.Kind = ast.BooleanValue
return value, nil
}

case "ID":
if kind == reflect.Int || kind == reflect.Int32 || kind == reflect.Int64 || kind == reflect.String {
value.Kind = ast.IntValue
}
default:
// assume custom scalars are ok
value.Kind = ast.StringValue
return value, nil
}
return nil, gqlerror.ErrorPathf(v.path, "cannot use %s as %s", kind.String(), typ.NamedType)
case ast.InputObject:
if val.Kind() != reflect.Map {
return nil, gqlerror.ErrorPathf(v.path, "must be a %s", def.Name)
}

value.Kind = ast.ObjectValue

// check for unknown fields
for _, name := range val.MapKeys() {
val.MapIndex(name)
fieldDef := def.Fields.ForName(name.String())
resetPath()
v.path = append(v.path, name.String())

if fieldDef == nil {
return nil, gqlerror.ErrorPathf(v.path, "unknown field")
}
}

for _, fieldDef := range def.Fields {
resetPath()
v.path = append(v.path, fieldDef.Name)

field := val.MapIndex(reflect.ValueOf(fieldDef.Name))
if !field.IsValid() {
if fieldDef.Type.NonNull {
return nil, gqlerror.ErrorPathf(v.path, "must be defined")
}
continue
}

if field.Kind() == reflect.Ptr || field.Kind() == reflect.Interface {
if fieldDef.Type.NonNull && field.IsNil() {
return nil, gqlerror.ErrorPathf(v.path, "cannot be null")
}
//allow null object field and skip it
if !fieldDef.Type.NonNull && field.IsNil() {
continue
}
field = field.Elem()
}

val, err := v.getVars(fieldDef.Type, field)
if err != nil {
return nil, err
}
value.Children = append(value.Children, &ast.ChildValue{
Name: fieldDef.Name,
Value: val,
})
}
default:
panic(fmt.Errorf("unsupported type %s", def.Kind))
}

return value, nil
}

func (v *varValidator) validateVarType(typ *ast.Type, val reflect.Value) *gqlerror.Error {
currentPath := v.path
resetPath := func() {
Expand Down