Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add secrets: inherit when calling release-info workflow #555

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

kevinmingtarja
Copy link
Member

@kevinmingtarja kevinmingtarja commented Nov 5, 2024

Description

https://github.com/hypermodeinc/modus/actions/runs/11673114915/job/32503157055 was failing as it didn't have access to the workflow secrets.

To solve this, we add secrets: inherit to pass all the calling workflow's secrets to the called workflow. This includes all secrets the calling workflow has access to, namely organization, repository, and environment secrets.

References:

Checklist

  • Code compiles correctly and linting passes locally
  • Tests for new functionality and regression tests for bug fixes added
  • Documentation added or updated
  • Entry added to the CHANGELOG.md file describing and linking to this PR

@kevinmingtarja kevinmingtarja requested a review from a team as a code owner November 5, 2024 02:34
@kevinmingtarja kevinmingtarja changed the title Add secrets: inherit when calling release-info workflow Add secrets: inherit when calling release-info workflow Nov 5, 2024
@kevinmingtarja kevinmingtarja enabled auto-merge (squash) November 5, 2024 02:35
@kevinmingtarja kevinmingtarja merged commit b6d6cd2 into main Nov 5, 2024
3 checks passed
@kevinmingtarja kevinmingtarja deleted the kevinm/inherit-secrets branch November 5, 2024 02:37
@mattjohnsonpint mattjohnsonpint changed the title Add secrets: inherit when calling release-info workflow ci: Add secrets: inherit when calling release-info workflow Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants