fix: logic for jwks endpoint unmarshalling was incorrect #594

jairad26 · 2024-11-19T16:38:16Z

Description

The loop currently checks for when the jwks env var isempty to unmarshall, when it should be the opposite. also it only resets the timer if it doesnt ifnd the env var, when it should do it regardless

Checklist

Code compiles correctly and linting passes locally
For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
Tests added for new functionality, or regression tests for bug fixes added as applicable
For public APIs, new features, etc., PR on docs repo staged and linked here

fix logic for jwks unmarshallling loop

6bb9694

jairad26 requested a review from a team as a code owner November 19, 2024 16:38

jairad26 changed the title ~~fix logic for jwks unmarshallling loop~~ fix: logic for jwks endpoint unmarshalling was incorrect Nov 19, 2024

.

77fe1c6

mattjohnsonpint approved these changes Nov 19, 2024

View reviewed changes

jairad26 merged commit e1769bf into main Nov 19, 2024
45 checks passed

jairad26 deleted the jai/hyp-2587-error-unexpected-end-of-json-input branch November 19, 2024 17:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: logic for jwks endpoint unmarshalling was incorrect #594

fix: logic for jwks endpoint unmarshalling was incorrect #594

jairad26 commented Nov 19, 2024 •

edited

Loading

fix: logic for jwks endpoint unmarshalling was incorrect #594

fix: logic for jwks endpoint unmarshalling was incorrect #594

Conversation

jairad26 commented Nov 19, 2024 • edited Loading

jairad26 commented Nov 19, 2024 •

edited

Loading