Code

misc code improvements#91

Code

Closed

tegk wants to merge 26 commits intohypermodeinc:masterhypermodeinc/ristretto:masterfrom tegk:masterCopy head branch name to clipboard

+19-26

Commits

Commits on Oct 17, 2019

• unnecessary type conversion

  

  tegk

  committed
  0fed73a

  Copy full SHA for 0fed73a

• TestMain should call os.Exit to set exit code otherwise its always zero even if it fails!

  

  tegk

  committed
  ae50d1b

  Copy full SHA for ae50d1b

• error strings should not end with punctation since they are usually printed following other context

  

  tegk

  committed
  86d2fa7

  Copy full SHA for 86d2fa7

• should omit type time.Duration from declaration of var wait; it will be inferred from the right-hand side

  

  tegk

  committed
  1bf42a6

  Copy full SHA for 1bf42a6

• acronyms should be capitalized

  

  tegk

  committed
  f875879

  Copy full SHA for f875879

• increment with ++ is the way to go

  

  tegk

  committed
  74d61c8

  Copy full SHA for 74d61c8

• trailing whitespace removed

  

  tegk

  committed
  91b4060

  Copy full SHA for 91b4060

• single case switch should be if statement

  

  tegk

  committed
  8d117f0

  Copy full SHA for 8d117f0

• replace else {if cond {}} with else if cond {}

  

  tegk

  committed
  9181856

  Copy full SHA for 9181856

• gofmt -s

  

  tegk

  committed
  dec484b

  Copy full SHA for dec484b

• TestMain should call os.Exit to set exit code otherwise its always zero even if it fails!

  tegk

  committed
  2310823

  Copy full SHA for 2310823

• error strings should not end with punctation since they are usually printed following other context

  

  tegk

  authored and

  tegk

  committed
  df38d06

  Copy full SHA for df38d06

• should omit type time.Duration from declaration of var wait; it will be inferred from the right-hand side

  tegk

  committed
  954cef3

  Copy full SHA for 954cef3

• acronyms should be capitalized

  tegk

  committed
  fd29622

  Copy full SHA for fd29622

• increment with ++ is the way to go

  tegk

  committed
  54cacf5

  Copy full SHA for 54cacf5

• trailing whitespace removed

  tegk

  committed
  8baf1cb

  Copy full SHA for 8baf1cb

• single case switch should be if statement

  tegk

  committed
  dfefa25

  Copy full SHA for dfefa25

• replace else {if cond {}} with else if cond {}

  tegk

  committed
  098e498

  Copy full SHA for 098e498

• gofmt -s

  tegk

  committed
  64e5834

  Copy full SHA for 64e5834

• Merge branch 'master' of https://github.com/tegk/ristretto

  tegk

  committed
  40b84bd

  Copy full SHA for 40b84bd

• single case switch should be if statement

  tegk

  committed
  e9795b2

  Copy full SHA for e9795b2

• replace else {if cond {}} with else if cond {}

  tegk

  committed
  1be4690

  Copy full SHA for 1be4690

• gofmt -s

  tegk

  committed
  569769d

  Copy full SHA for 569769d

• Merge branch 'master' of https://github.com/tegk/ristretto

  tegk

  committed
  1be40e1

  Copy full SHA for 1be40e1

• Merge branch 'master' of https://github.com/tegk/ristretto

  tegk

  committed
  aeaab35

  Copy full SHA for aeaab35

Commits on Oct 21, 2019

• resolving maintainers requewsts

  tegk

  committed
  cd78c9e

  Copy full SHA for cd78c9e