Improve memory handling #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @vadymmarkov and @attila-at-hyper to be potential reviewers |
| @@ -37,6 +38,9 @@ public struct DefaultCacheConverter<T> { | |||
|
|
|||
| /** | |||
| Encodes an instance to NSData | |||
|
|
|||
There was a problem hiding this comment.
Sometimes I feel the documentation is a bit unnecessary. I can see that by looking at the function signature
There was a problem hiding this comment.
I agree, they are a bit obvious but where would you draw the line? Also, the linter forces you to add documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the memory handling when using Cache.
Before, we shared the same variable for
DiskStorageandMemoryStoragewhich ended up not being what we want. And here is why:DiskStorage’s limit is based on actual disk space where asMemoryStorageis based on the amount of objects that you want to keep in memory.So this PR adds another variable to the configuration called
maxObjects, it defaults to0so that it does not break the current implementations but the components usingCachenow gain more fine-grained control over both storages.Also, internally inside
didSetinMemoryStoragebut it was never called because it was only called insideinit.As and added bonus, this PR also adds SwiftLint and fixes some of the warnings that it introduces.
With
Imaginarythis change made quiet an impact on memory usage;Before
### After