Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/os x support #23

Merged
merged 4 commits into from
Jun 23, 2016
Merged

Feature/os x support #23

merged 4 commits into from
Jun 23, 2016

Conversation

zenangst
Copy link
Contributor

@zenangst zenangst commented Jun 23, 2016

This PR adds support for Imaginary on OS X. It refactors the project structure to separate classes and structs depending on platform.

The inspiration for this PR comes from SDWebImage.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vadymmarkov and @aashishdhawan to be potential reviewers

@vadymmarkov vadymmarkov merged commit 0e3058d into master Jun 23, 2016
@vadymmarkov vadymmarkov deleted the feature/os-x-support branch June 23, 2016 13:51
@vadymmarkov
Copy link
Contributor

@zenangst

self.fetcher = nil
}

imageCache.object(key) { [weak self] object in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code looks the same for UIImageView ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants