-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the .image property of a LightboxImage instance after Lightbox has downloaded an image via URL #115
Conversation
…e fetched by the Lightbox itself via given URL. This will enable apps to be able to access and use images, downloaded by Lightbox.
@vitalii-tym Hi, thanks for your PR. This is good addition. What do you think about when user opens and closes Lightbox in a short time, so that it still hasn't finished downloading all the images? |
If the image was not yet downloaded, the .image property is still going to be nil. |
@onmyway133 I took a second look and found that there was indeed a strong capture of self. Fixed now. Thanks for the heads up. |
…d, so that activity indicators are correcty shown
# Conflicts: # Source/LightboxImage.swift
sorry, too much commits in here now. Made another PR with only one concrete commit here #122 |
This change allows apps to access the images inside LightboxImage even if those images were downloaded from an external URL provided by the app.
Can be useful, for example, when an app needs to provide sharing functionality.
See example of such a usage in #98