Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1080: Android fix theme switch #807

Merged
merged 2 commits into from
Dec 21, 2023
Merged

ALTAPPS-1080: Android fix theme switch #807

merged 2 commits into from
Dec 21, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Dec 20, 2023 •
edited
Loading

YouTrack Issues:
ALTAPPS-1080

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Move nightMode setting from Activity.onCreate to Application.onCreate to avoid activity recreation;
  • Update appcompat lib.

@XanderZhu
Fix theme switch;
5785565 
androidx.appcompat 1.6.1
@XanderZhu XanderZhu added bug Something isn't working android Android module task labels Dec 20, 2023
@XanderZhu XanderZhu added this to the 1.46 milestone Dec 20, 2023
@XanderZhu XanderZhu self-assigned this Dec 20, 2023
@XanderZhu XanderZhu requested a review from ivan-magda December 20, 2023 15:45
@XanderZhu XanderZhu marked this pull request as ready for review December 20, 2023 15:46
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Dec 20, 2023
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Dec 20, 2023
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Dec 21, 2023
@ivan-magda ivan-magda merged commit b3f8c64 into develop Dec 21, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1080/Android-Dark-mode-switch-problem branch December 21, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task bug Something isn't working
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda