-
Notifications
You must be signed in to change notification settings - Fork 1
Feature jacobians #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to mimimize memory usage.
…ecies Air using MPP fluid model in implicit mode.
…xtures as monoatomic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Jacobian/implicit capabilities for Mutation++ integration by updating the submodule reference and implementing new methods for computing chemistry and vibrational energy source term Jacobians. The changes enable implicit time stepping with Mutation++ fluid models in SU2.
- Updates Mutation++ submodule to a fork with Jacobian features
- Implements chemistry and vibrational energy source term Jacobian computation methods
- Removes the restriction preventing implicit time schemes with Mutation++ models
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| subprojects/Mutationpp | Updates submodule commit to include Jacobian features |
| meson_scripts/init.py | Updates Mutation++ repository URL and commit hash |
| SU2_CFD/src/numerics/NEMO/CNEMONumerics.cpp | Adds viscous Jacobian computation for 15-species case |
| SU2_CFD/src/fluid/CMutationTCLib.cpp | Implements Jacobian computation methods and removes implicit restriction |
| SU2_CFD/include/fluid/CMutationTCLib.hpp | Declares new Jacobian vectors and method signatures |
| Common/src/CConfig.cpp | Fixes gas model comparison and removes Mutation++ implicit restriction |
| .gitmodules | Updates Mutation++ submodule configuration to point to new fork |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.gitmodules
Outdated
| url = https://github.com/EvertBunschoten/MLPCpp.git | ||
| [submodule "subprojects/Mutationpp"] | ||
| path = subprojects/Mutationpp | ||
| url = git@github.com:hypersonic-lab/Mutationpp.git |
Copilot
AI
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using SSH URL (git@github.com:) may cause issues for users without SSH keys configured. Consider using HTTPS URL (https://github.com/) for better accessibility.
| url = git@github.com:hypersonic-lab/Mutationpp.git | |
| url = https://github.com/hypersonic-lab/Mutationpp.git |
Common/src/CConfig.cpp
Outdated
|
|
||
| monoatomic = GetGasModel() == "ARGON"; | ||
| // monoatomic = GetGasModel() == "ARGON"; //--original | ||
| monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; //--modified by RSCD |
Copilot
AI
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment format '//--modified by RSCD' doesn't follow standard commenting practices. Consider using a more descriptive comment explaining why the change was needed.
| monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; //--modified by RSCD | |
| monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; // Compare gas model to "ARGON" in a case-insensitive way for robustness. |
4529fee to
1734b40
Compare
1734b40 to
f3dd125
Compare
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Trying to add Raghava's contributions for the Mutationpp Jacobian/implicit capabilities.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.