Skip to content

Conversation

@Hanquist
Copy link

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Trying to add Raghava's contributions for the Mutationpp Jacobian/implicit capabilities.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Jacobian/implicit capabilities for Mutation++ integration by updating the submodule reference and implementing new methods for computing chemistry and vibrational energy source term Jacobians. The changes enable implicit time stepping with Mutation++ fluid models in SU2.

  • Updates Mutation++ submodule to a fork with Jacobian features
  • Implements chemistry and vibrational energy source term Jacobian computation methods
  • Removes the restriction preventing implicit time schemes with Mutation++ models

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
subprojects/Mutationpp Updates submodule commit to include Jacobian features
meson_scripts/init.py Updates Mutation++ repository URL and commit hash
SU2_CFD/src/numerics/NEMO/CNEMONumerics.cpp Adds viscous Jacobian computation for 15-species case
SU2_CFD/src/fluid/CMutationTCLib.cpp Implements Jacobian computation methods and removes implicit restriction
SU2_CFD/include/fluid/CMutationTCLib.hpp Declares new Jacobian vectors and method signatures
Common/src/CConfig.cpp Fixes gas model comparison and removes Mutation++ implicit restriction
.gitmodules Updates Mutation++ submodule configuration to point to new fork
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

.gitmodules Outdated
url = https://github.com/EvertBunschoten/MLPCpp.git
[submodule "subprojects/Mutationpp"]
path = subprojects/Mutationpp
url = git@github.com:hypersonic-lab/Mutationpp.git
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using SSH URL (git@github.com:) may cause issues for users without SSH keys configured. Consider using HTTPS URL (https://github.com/) for better accessibility.

Suggested change
url = git@github.com:hypersonic-lab/Mutationpp.git
url = https://github.com/hypersonic-lab/Mutationpp.git

Copilot uses AI. Check for mistakes.

monoatomic = GetGasModel() == "ARGON";
// monoatomic = GetGasModel() == "ARGON"; //--original
monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; //--modified by RSCD
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment format '//--modified by RSCD' doesn't follow standard commenting practices. Consider using a more descriptive comment explaining why the change was needed.

Suggested change
monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; //--modified by RSCD
monoatomic = StringToUpperCase(GetGasModel()) == "ARGON"; // Compare gas model to "ARGON" in a case-insensitive way for robustness.

Copilot uses AI. Check for mistakes.
@raghava-davuluri raghava-davuluri added the changelog:feature Marks PRs that add or change user-visible functionality. label Aug 19, 2025
@raghava-davuluri raghava-davuluri merged commit a624340 into chanl Aug 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:feature Marks PRs that add or change user-visible functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants