-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eelsdb blocks requests bugfix #66
Conversation
added headers to request.get
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 87.77% 88.47% +0.70%
==========================================
Files 67 67
Lines 7286 7287 +1
Branches 1179 1179
==========================================
+ Hits 6395 6447 +52
+ Misses 626 571 -55
- Partials 265 269 +4 ☔ View full report in Codecov by Sentry. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changelog entry as described in the pull request template:
https://github.com/hyperspy/exspy/blob/main/.github/PULL_REQUEST_TEMPLATE.md
Like so? I edited first coment |
For the changelog entry, you need to add a Here is an example of a commit adding a changelog entry: bae3882 The template is here as a guideline, which explains the main steps for contributors to know what they need to do but also as a reminder / check list (including experienced contributors 😄). |
I think I got it now. Easy to tell it was my first contribution. 😅 |
Thank you @PauTorru. |
Description of the change
A few sentences and/or a bulleted list to describe and motivate the change:
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:exspy
build of this PR (link in github checks)Minimal example of the bug fix or the new feature