Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eelsdb blocks requests bugfix #66

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

PauTorru
Copy link
Contributor

@PauTorru PauTorru commented Jul 2, 2024

Description of the change

A few sentences and/or a bulleted list to describe and motivate the change:

  • Added headers to request.get calls to eelsdb

Progress of the PR

  • Change implemented (can be split into several points),
  • docstring updated (if appropriate),
  • update user guide (if appropriate),
  • added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

Minimal example of the bug fix or the new feature

from exspy.misc.eels import eelsdb
s = eelsdb.eelsdb(spectrum_type="coreloss",element="O",edge="K")

added headers to request.get
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.47%. Comparing base (e63bd21) to head (7694c00).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   87.77%   88.47%   +0.70%     
==========================================
  Files          67       67              
  Lines        7286     7287       +1     
  Branches     1179     1179              
==========================================
+ Hits         6395     6447      +52     
+ Misses        626      571      -55     
- Partials      265      269       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PauTorru PauTorru changed the title eelsbd blocks requests bugfix eelsdb blocks requests bugfix Jul 2, 2024
@ericpre
Copy link
Member

ericpre commented Jul 2, 2024

pre-commit.ci autofix

@ericpre ericpre linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link
Member

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry as described in the pull request template:
https://github.com/hyperspy/exspy/blob/main/.github/PULL_REQUEST_TEMPLATE.md

@PauTorru
Copy link
Contributor Author

PauTorru commented Jul 2, 2024

Can you add a changelog entry as described in the pull request template: https://github.com/hyperspy/exspy/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Like so? I edited first coment

@ericpre
Copy link
Member

ericpre commented Jul 2, 2024

For the changelog entry, you need to add a rst file summarising the changes and with the correct name. This is explained in more detailed in upcoming_changes/README.rst.

Here is an example of a commit adding a changelog entry: bae3882

The template is here as a guideline, which explains the main steps for contributors to know what they need to do but also as a reminder / check list (including experienced contributors 😄).

@PauTorru
Copy link
Contributor Author

I think I got it now. Easy to tell it was my first contribution. 😅

@ericpre ericpre merged commit 04572ec into hyperspy:main Jul 11, 2024
17 checks passed
@ericpre
Copy link
Member

ericpre commented Jul 11, 2024

Thank you @PauTorru.
There are a number of things to figure out when contributing the first time and it is not always easy to appreciate what is necessary or not, its relevance, etc.! :)

@PauTorru PauTorru deleted the eelsbd_headers branch July 11, 2024 14:22
@ericpre ericpre added this to the v0.2.1 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eelsdb queries
2 participants