Remove unsupported chromedriver-helper, make use of webdrivers in hyper-spec #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromedriver-helper has been unsupported for a while now in favor of webdrivers. webdrivers is included in the hyper-spec gemfile, but isn't actually used.
I usually end up fighting against chromedriver-helper, and lately it's installing a beta version that doesn't support the latest normal release of chrome. This prevents any of the specs from running for me. Removing chromedriver-helper and making use of webdrivers is working perfectly, and it also simplifies the travis-ci config a bit.
Unless there's a specific reason we're using chromedriver-helper, I think this will help clean the development environment a bit.