Skip to content

chore: marking trace, span related ids as non-groupable #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: marking trace, span related ids as non-groupable #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...nfig-bootstrapper/attribute-service/hypertrace-core/hypertrace_core_event_attributes.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ commands = [
fqn: Span.id,
key: id,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to add rollback block with action update to go back to true value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but also you shouldn't change a historical command. You want to add a new command with its own rollback that describes the desired and previous state.

display_name: Span ID,
scope: EVENT,
sources: [QS],
Expand Down Expand Up @@ -74,7 +74,7 @@ commands = [
fqn: Span.attributes.trace_id,
key: traceId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Trace ID,
scope: EVENT,
sources: [QS],
Expand All @@ -96,7 +96,7 @@ commands = [
fqn: Span.attributes.parent_span_id,
key: parentSpanId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Parent Span ID,
scope: EVENT,
sources: [QS],
Expand Down
2 changes: 1 addition & 1 deletion ...nfig-bootstrapper/attribute-service/hypertrace-core/hypertrace_core_trace_attributes.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ commands = [
fqn: Trace.id,
key: id,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Trace ID,
scope: TRACE,
sources: [QS],
Expand Down
4 changes: 2 additions & 2 deletions ...igs/config-bootstrapper/attribute-service/hypertrace/hypertrace_api_trace_attributes.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ commands = [
fqn: Api.Trace.id,
key: apiTraceId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Endpoint Trace ID,
scope: API_TRACE,
sources: [QS],
Expand All @@ -23,7 +23,7 @@ commands = [
fqn: Api.Trace.traceId,
key: traceId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Trace ID,
scope: API_TRACE,
sources: [QS],
Expand Down
4 changes: 2 additions & 2 deletions ...config-bootstrapper/attribute-service/hypertrace/hypertrace_backend_trace_attributes.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ commands = [
fqn: Backend.Trace.id,
key: backendTraceId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Backend Trace ID,
scope: BACKEND_TRACE,
sources: [QS],
Expand All @@ -23,7 +23,7 @@ commands = [
fqn: Backend.Trace.trace_id,
key: traceId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Trace ID,
scope: BACKEND_TRACE,
sources: [QS],
Expand Down
2 changes: 2 additions & 0 deletions ...igs/config-bootstrapper/attribute-service/hypertrace/hypertrace_log_event_attributes.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ commands = [
value_kind: TYPE_STRING,
display_name: Span ID,
scope_string: LOG_EVENT,
groupable: false,
sources: [QS],
type: ATTRIBUTE,
internal: false
Expand All @@ -35,6 +36,7 @@ commands = [
value_kind: TYPE_STRING,
display_name: Trace ID,
scope_string: LOG_EVENT,
groupable: false,
sources: [QS],
type: ATTRIBUTE,
internal: false
Expand Down
2 changes: 1 addition & 1 deletion .../configs/config-bootstrapper/attribute-service/hypertrace/hypertrace_span_attributes.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ commands = [
fqn: Api.Trace.id,
key: apiTraceId,
value_kind: TYPE_STRING,
groupable: true,
groupable: false,
display_name: Endpoint Trace ID,
scope: EVENT,
sources: [QS],
Expand Down