ENG-57596 Add get label application rule api #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
============================================
- Coverage 79.93% 76.14% -3.80%
- Complexity 496 543 +47
============================================
Files 55 59 +4
Lines 2432 2712 +280
Branches 108 123 +15
============================================
+ Hits 1944 2065 +121
- Misses 427 573 +146
- Partials 61 74 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| try { | ||
| RequestContext requestContext = RequestContext.CURRENT.get(); | ||
| LabelApplicationRule labelApplicationRule = | ||
| getAllLabelApplicationRules(requestContext).stream() |
There was a problem hiding this comment.
We don't need to fetch all label application rules in this case. Use getData(...) method in store impl.
...ertrace/label/application/rule/config/service/v1/label_application_rule_config_service.proto
Outdated
Show resolved
Hide resolved
| RequestContext requestContext = RequestContext.CURRENT.get(); | ||
| LabelApplicationRule rule = | ||
| this.labelApplicationRuleStore | ||
| .getData(requestContext, request.getId()) |
There was a problem hiding this comment.
This would also need to respect the deleted system IDs (another benefit from sharing the existing RPC)
.../hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
.../hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
.../hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
aaron-steinfeld
previously approved these changes
Feb 20, 2025
skjindal93
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.