Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

chore | adding the eds filter support to qs explore query #157

Merged
merged 19 commits into from
Dec 19, 2023

Conversation

aman-bansal
Copy link
Member

No description provided.

@aman-bansal aman-bansal requested a review from a team December 6, 2022 08:59
@aman-bansal aman-bansal marked this pull request as draft December 6, 2022 09:00
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (f280fa7) 81.46% compared to head (740213e) 82.55%.

Files Patch % Lines
...rtrace/gateway/service/explore/RequestHandler.java 91.15% 5 Missing and 5 partials ⚠️
...ice/explore/entity/EntityServiceEntityFetcher.java 90.00% 3 Missing and 2 partials ⚠️
...common/converters/QueryAndGatewayDtoConverter.java 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #157      +/-   ##
============================================
+ Coverage     81.46%   82.55%   +1.09%     
- Complexity     1334     1367      +33     
============================================
  Files           125      125              
  Lines          5972     6066      +94     
  Branches        490      501      +11     
============================================
+ Hits           4865     5008     +143     
+ Misses          865      807      -58     
- Partials        242      251       +9     
Flag Coverage Δ
unit 82.55% <90.65%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@aman-bansal aman-bansal marked this pull request as ready for review December 13, 2022 04:52
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Unit Test Results

  64 files  +1    64 suites  +1   8s ⏱️ -1s
356 tests +1  356 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit e536f69. ± Comparison against base commit 1c33b3c.

@aman-bansal aman-bansal requested a review from a team as a code owner August 22, 2023 06:33
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Test Results

366 tests  +2   366 ✔️ +2   8s ⏱️ ±0s
  67 suites +1       0 💤 ±0 
  67 files   +1       0 ±0 

Results for commit 740213e. ± Comparison against base commit f280fa7.

This pull request removes 32 and adds 19 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] simple-selection
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] grouped-time-aggregation-with-group-limit-and-the-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] grouped-time-aggregation-with-group-limit-with-null-value-group
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [13] group-by-with-group-limit-and-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [14] time-aggregations
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [15] aggregations-with-multiple-groupbys-and-the-rest-deprecated
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] simple-aggregations
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [2] aggregations-with-groupby
…

♻️ This comment has been updated with latest results.

@aman-bansal aman-bansal merged commit 481e7a3 into main Dec 19, 2023
9 checks passed
@aman-bansal aman-bansal deleted the aman/eds_filter branch December 19, 2023 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants