Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

chore: update to ng10 #18

Merged
merged 4 commits into from
Jul 17, 2020
Merged

chore: update to ng10 #18

merged 4 commits into from
Jul 17, 2020

Conversation

aaron-steinfeld
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #18 into master will decrease coverage by 13.45%.
The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #18       +/-   ##
===========================================
- Coverage   81.95%   68.50%   -13.46%     
===========================================
  Files         376      376               
  Lines        6557     6572       +15     
  Branches      807      743       -64     
===========================================
- Hits         5374     4502      -872     
- Misses       1173     2064      +891     
+ Partials       10        6        -4     
Impacted Files Coverage Δ
...rc/filtering/filters/key-value/key-value-filter.ts 0.00% <0.00%> (ø)
...ts/src/filtering/filters/numeric/numeric-filter.ts 0.00% <0.00%> (ø)
...mestamp/timestamp-table-cell-renderer.component.ts 44.44% <ø> (-55.56%) ⬇️
...src/table/renderers/table-cell-renderer.service.ts 88.46% <ø> (-7.70%) ⬇️
...ing/src/pages/trace-detail/trace-detail.service.ts 0.00% <ø> (-97.68%) ⬇️
.../filter-bar/filter/parser/filter-parser.service.ts 34.04% <ø> (-46.81%) ⬇️
...ell/metric/metric-table-cell-renderer.component.ts 100.00% <ø> (ø)
...aphql/table/spans/spans-table-data-source.model.ts 33.33% <ø> (ø)
...ard/data/graphql/trace/traces-data-source.model.ts 75.00% <ø> (ø)
...ndlers/spans/span-graphql-query-handler.service.ts 100.00% <ø> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da8980...a72059c. Read the comment docs.

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review July 17, 2020 16:15
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner July 17, 2020 16:15
"lodash-es": "^4.17.15"
},
"dependencies": {
"tslib": "^2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not a peer dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear to me - the ng update command moved it to a dependency from peer dep. I would guess it's to allow better cross-version support, since the tslib had a breaking change, and using multiple copies at runtime isn't problematic except for in bundle size.

TableCellAlignmentType,
TableCellRenderer,
TableCellRendererComponent,
TableColumnConfig
TableColumnConfig,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these ordering changes showing up? Any changes in the default lint rule ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier and tslint have disagreed on the alphabetical ordering wrt caps - I think that finally got resolved in palantir/tslint#4064

"rxjs": "~6.5.4"
"@angular/common": "^10.0.4",
"@angular/core": "^10.0.4",
"@angular/flex-layout": "^10.0.0-beta.32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this one is still in beta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaron-steinfeld aaron-steinfeld merged commit d7f3075 into master Jul 17, 2020
@aaron-steinfeld aaron-steinfeld deleted the update-ng branch July 17, 2020 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants