Skip to content

Commit 29f2bdd

Browse files
feat: log records in the span sheet (#819)
* feat: log records in the span sheet
1 parent c5b8a42 commit 29f2bdd

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

projects/distributed-tracing/src/shared/components/span-detail/span-detail.component.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ import { SpanDetailLayoutStyle } from './span-detail-layout-style';
4646
<ht-tab label="Exit Calls" *ngIf="this.showExitCallsTab">
4747
<ht-span-exit-calls [exitCalls]="this.spanData.exitCallsBreakup"></ht-span-exit-calls>
4848
</ht-tab>
49+
<ht-tab *ngIf="this.showLogEventstab" label="Logs" [badge]="this.totalLogEvents">
50+
<ht-log-events-table
51+
[logEvents]="this.spanData?.logEvents"
52+
[spanStartTime]="this.spanData?.startTime"
53+
></ht-log-events-table>
54+
</ht-tab>
4955
</ht-tab-group>
5056
</div>
5157
`
@@ -66,12 +72,16 @@ export class SpanDetailComponent implements OnChanges {
6672
public showRequestTab?: boolean;
6773
public showResponseTab?: boolean;
6874
public showExitCallsTab?: boolean;
75+
public showLogEventstab?: boolean;
76+
public totalLogEvents?: number;
6977

7078
public ngOnChanges(changes: TypedSimpleChanges<this>): void {
7179
if (changes.spanData) {
7280
this.showRequestTab = !isEmpty(this.spanData?.requestHeaders) || !isEmpty(this.spanData?.requestBody);
7381
this.showResponseTab = !isEmpty(this.spanData?.responseHeaders) || !isEmpty(this.spanData?.responseBody);
7482
this.showExitCallsTab = !isEmpty(this.spanData?.exitCallsBreakup);
83+
this.showLogEventstab = !isEmpty(this.spanData?.logEvents);
84+
this.totalLogEvents = (this.spanData?.logEvents ?? []).length;
7585
}
7686
}
7787
}

projects/distributed-tracing/src/shared/components/span-detail/span-detail.module.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import {
1111
ToggleButtonModule,
1212
TooltipModule
1313
} from '@hypertrace/components';
14+
import { LogEventsTableModule } from '../log-events/log-events-table.module';
1415
import { SpanExitCallsModule } from './exit-calls/span-exit-calls.module';
1516
import { SpanDetailTitleHeaderModule } from './headers/title/span-detail-title-header.module';
1617
import { SpanRequestDetailModule } from './request/span-request-detail.module';
@@ -34,7 +35,8 @@ import { SpanTagsDetailModule } from './tags/span-tags-detail.module';
3435
LoadAsyncModule,
3536
ListViewModule,
3637
SpanDetailTitleHeaderModule,
37-
SpanExitCallsModule
38+
SpanExitCallsModule,
39+
LogEventsTableModule
3840
],
3941
declarations: [SpanDetailComponent],
4042
exports: [SpanDetailComponent]

0 commit comments

Comments
 (0)