feat: log records in the span sheet #819

itssharmasandeep · 2021-05-04T11:28:07Z

Description

Log records in the span sheet

Testing

Local testing done

Checklist:

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules
PR dependency-1 feat: fetching log records and showing log icon #817

codecov · 2021-05-04T11:31:52Z

Codecov Report

Merging #819 (a036408) into log-components (c5b8a42) will increase coverage by 0.03%.
The diff coverage is 88.23%.

❗ Current head a036408 differs from pull request most recent head dc7efe1. Consider uploading reports for the commit dc7efe1 to get more accurate results

@@                Coverage Diff                 @@
##           log-components     #819      +/-   ##
==================================================
+ Coverage           85.44%   85.48%   +0.03%     
==================================================
  Files                 796      801       +5     
  Lines               16274    16310      +36     
  Branches             1932     1936       +4     
==================================================
+ Hits                13906    13942      +36     
  Misses               2336     2336              
  Partials               32       32

Impacted Files	Coverage Δ
...l/table/log-events/log-events-data-source.model.ts	`69.23% <69.23%> (ø)`
...pan-detail/log-events/span-log-events.component.ts	`100.00% <100.00%> (ø)`
...pan-detail/log-events/span-log-events.dashboard.ts	`100.00% <100.00%> (ø)`
...s/span-detail/log-events/span-log-events.module.ts	`100.00% <100.00%> (ø)`
...ed/components/span-detail/span-detail.component.ts	`100.00% <100.00%> (ø)`
...hared/components/span-detail/span-detail.module.ts	`100.00% <100.00%> (ø)`
...shboard/data/graphql/graphql-data-source.module.ts	`100.00% <100.00%> (ø)`
...able/cells/data-parsers/table-cell-no-op-parser.ts	`55.55% <0.00%> (-33.34%)`	⬇️
...d/widgets/table/table-widget-renderer.component.ts	`45.27% <0.00%> (-4.01%)`	⬇️
...te/entities-attribute-options-data-source.model.ts	`55.55% <0.00%> (-1.59%)`	⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8a42...dc7efe1. Read the comment docs.

arjunlalb · 2021-05-04T12:47:28Z

...istributed-tracing/src/shared/components/span-detail/log-events/span-log-events.dashboard.ts

@@ -0,0 +1,52 @@
+import { TableMode, TableStyle } from '@hypertrace/components';
+import { ObservabilityTableCellType } from '../../../../../../observability/src/shared/components/table/observability-table-cell-type';


import from @hypertrace/observability

This reverts commit 589e8a8.

itssharmasandeep · 2021-05-07T14:52:07Z

Not big changes, so merging to other branch!!

github-actions · 2021-05-07T14:54:17Z

Unit Test Results

    4 files ±0 252 suites ±0 15m 3s ⏱️ +45s
901 tests ±0 901 ✔️ ±0 0 💤 ±0 0 ❌ ±0
907 runs ±0 907 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit dc7efe1. ± Comparison against base commit c5b8a42.

feat: log records in the span sheet

892858c

itssharmasandeep requested a review from a team as a code owner May 4, 2021 11:28