Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
892858c
feat: log records in the span sheet
itssharmasandeep May 4, 2021
a39e502
fix: property validation in data source
itssharmasandeep May 4, 2021
589e8a8
fix: addressing review comments
itssharmasandeep May 4, 2021
73d8343
Merge branch 'log-components' into log-records
itssharmasandeep May 4, 2021
5ebaa4b
Merge branch 'log-components' into log-records
itssharmasandeep May 4, 2021
9909cda
Revert "fix: addressing review comments"
itssharmasandeep May 4, 2021
e18dd3c
fix: addressing review comment
itssharmasandeep May 4, 2021
6a8e15e
fix: relative timestamp
itssharmasandeep May 5, 2021
17f4dfa
Merge branch 'log-components' into log-records
itssharmasandeep May 5, 2021
ece1205
Merge branch 'log-components' into log-records
itssharmasandeep May 5, 2021
9e70f1f
Merge branch 'log-components' into log-records
itssharmasandeep May 5, 2021
545b805
Merge branch 'log-components' into log-records
itssharmasandeep May 6, 2021
8aa8ff7
Merge branch 'log-components' into log-records
itssharmasandeep May 6, 2021
381ed20
Merge branch 'log-components' into log-records
itssharmasandeep May 6, 2021
4d1af9a
fix: test case
itssharmasandeep May 6, 2021
33e2915
fix: test case
itssharmasandeep May 6, 2021
99ac26f
Merge branch 'log-components' into log-records
itssharmasandeep May 6, 2021
a036408
Merge branch 'log-components' into log-records
itssharmasandeep May 6, 2021
de6453d
Merge branch 'log-components' into log-records
itssharmasandeep May 7, 2021
1255a4b
fix: using log events table
itssharmasandeep May 7, 2021
92726b6
Merge branch 'log-components' into log-records
itssharmasandeep May 7, 2021
dc7efe1
fix: using log events table
itssharmasandeep May 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ import { SpanDetailLayoutStyle } from './span-detail-layout-style';
<ht-tab label="Exit Calls" *ngIf="this.showExitCallsTab">
<ht-span-exit-calls [exitCalls]="this.spanData.exitCallsBreakup"></ht-span-exit-calls>
</ht-tab>
<ht-tab *ngIf="this.showLogEventstab" label="Logs" [badge]="this.totalLogEvents">
<ht-log-events-table
[logEvents]="this.spanData?.logEvents"
[spanStartTime]="this.spanData?.startTime"
></ht-log-events-table>
</ht-tab>
</ht-tab-group>
</div>
`
Expand All @@ -66,12 +72,16 @@ export class SpanDetailComponent implements OnChanges {
public showRequestTab?: boolean;
public showResponseTab?: boolean;
public showExitCallsTab?: boolean;
public showLogEventstab?: boolean;
public totalLogEvents?: number;

public ngOnChanges(changes: TypedSimpleChanges<this>): void {
if (changes.spanData) {
this.showRequestTab = !isEmpty(this.spanData?.requestHeaders) || !isEmpty(this.spanData?.requestBody);
this.showResponseTab = !isEmpty(this.spanData?.responseHeaders) || !isEmpty(this.spanData?.responseBody);
this.showExitCallsTab = !isEmpty(this.spanData?.exitCallsBreakup);
this.showLogEventstab = !isEmpty(this.spanData?.logEvents);
this.totalLogEvents = (this.spanData?.logEvents ?? []).length;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
ToggleButtonModule,
TooltipModule
} from '@hypertrace/components';
import { LogEventsTableModule } from '../log-events/log-events-table.module';
import { SpanExitCallsModule } from './exit-calls/span-exit-calls.module';
import { SpanDetailTitleHeaderModule } from './headers/title/span-detail-title-header.module';
import { SpanRequestDetailModule } from './request/span-request-detail.module';
Expand All @@ -34,7 +35,8 @@ import { SpanTagsDetailModule } from './tags/span-tags-detail.module';
LoadAsyncModule,
ListViewModule,
SpanDetailTitleHeaderModule,
SpanExitCallsModule
SpanExitCallsModule,
LogEventsTableModule
],
declarations: [SpanDetailComponent],
exports: [SpanDetailComponent]
Expand Down