feat: add option to open link in new tab #1019
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1019 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 820 820
Lines 16863 16864 +1
Branches 2190 2190
=======================================
+ Hits 14344 14345 +1
Misses 2488 2488
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -12,6 +12,8 @@ import { EMPTY, Observable } from 'rxjs'; | |||
| <a | |||
| *htLetAsync="this.navData$ as navData" | |||
| class="ht-link" | |||
| target="{{ this.openInNewTab ? '_blank' : '' }}" | |||
There was a problem hiding this comment.
how's this differ from the existing way of doing this?
This component takes an ExternalNavigationParams as an input, which includes window handling.
There was a problem hiding this comment.
Hmm. I thought it suspicious that we didn't have this already. I though that might be how, but it didn't seem to work when I was playing with it. I'll circle back and try again.
There was a problem hiding this comment.
ExternalNavigationParams option should support this.
This reverts commit ece0d95.
Description
This provides an option to open links in a new tab.