Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jul 23, 2021

Description

  • Changing icon size.

Testing

Visual testing

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner July 23, 2021 23:09
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1021 (0ccd9d9) into main (ece0d95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16864    16864           
  Branches     2190     2190           
=======================================
  Hits        14345    14345           
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...ponents/src/summary-list/summary-list.component.ts 84.61% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece0d95...0ccd9d9. Read the comment docs.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit 260b9f9 into main Jul 23, 2021
@jake-bassett jake-bassett deleted the SummaryListIconSizeFixed branch July 23, 2021 23:16
@@ -2,6 +2,7 @@ import { ChangeDetectionStrategy, Component, EventEmitter, Input, Output } from
import { IconType } from '@hypertrace/assets-library';
import { PrimitiveValue } from '@hypertrace/common';
import { startCase } from 'lodash-es';
import { IconSize } from '../public-api';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix import

@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   17m 28s ⏱️ - 1m 11s
945 tests ±0  945 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
952 runs  ±0  952 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 260b9f9. ± Comparison against base commit ece0d95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants