Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

This PR fixes an issue with asynchronously created navItem lists not updating after initial load.

@jake-bassett jake-bassett requested a review from a team as a code owner July 28, 2021 00:21
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1032 (3cc2bae) into main (5819213) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1032   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16864    16865    +1     
  Branches     2190     2190           
=======================================
+ Hits        14345    14346    +1     
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...onents/src/navigation/navigation-list.component.ts 84.61% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5819213...3cc2bae. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 1a5f070 into main Jul 28, 2021
@anandtiwary anandtiwary deleted the fix-async-nav-items-updating branch July 28, 2021 01:20
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   18m 51s ⏱️ + 2m 5s
945 tests ±0  945 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
952 runs  ±0  952 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1a5f070. ± Comparison against base commit 5819213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants