Skip to content

fix: donut chart text font size fix #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 30, 2021
Merged

fix: donut chart text font size fix #1039

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8bf3da5
fix: donut chart fixes
itssharmasandeep Jul 13, 2021
5599c6a
Revert "fix: donut chart fixes"
itssharmasandeep Jul 13, 2021
88d3bd4
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 15, 2021
cd18474
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 19, 2021
2aa1a9b
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 20, 2021
111e41d
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 26, 2021
9b40fc4
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 28, 2021
00b1e07
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 29, 2021
f81b19d
Merge branch 'main' of github.com:hypertrace/hypertrace-ui
itssharmasandeep Jul 30, 2021
0266be7
fix: donut value text size fix
itssharmasandeep Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/observability/src/shared/components/donut/donut-builder.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@ export class DonutBuilderService extends D3VisualizationBuilderService<
visualizationContainer
.select(selector(DonutBuilderService.DONUT_VALUE_TITLE_CLASS))
.attr('transform', `translate(0,-${dimensions.donutInnerRadius / 2})`)
.style(
.attr(
'font-size',
Math.min(Math.floor(dimensions.donutInnerRadius / 8), DonutBuilderService.MAX_FONT_SIZE_FOR_TITLE)
);

visualizationContainer
.select(selector(DonutBuilderService.DONUT_VALUE_CLASS))
.attr('transform', `translate(0,-${dimensions.donutInnerRadius / 4})`)
.style(
.attr(
'font-size',
Math.min(Math.floor(dimensions.donutInnerRadius / 2), DonutBuilderService.MAX_FONT_SIZE_FOR_VALUE)
);
Expand Down