Skip to content

feat: removing unused type in tickCount variable #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2021
Merged

feat: removing unused type in tickCount variable #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f312110
feat: removing unused type in tickCount variable
Aug 2, 2021
f13d109
Merge branch 'main' into AdjustingTickCountType
palbizu Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
"d3-scale": "^3.3.0",
"d3-selection": "^1.4.2",
"d3-shape": "^1.3.5",
"d3-time": "^2.1.1",
"d3-transition": "^1.2.0",
"d3-zoom": "^1.8.3",
"graphql": "^15.5.1",
Expand Down
3 changes: 1 addition & 2 deletions projects/observability/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
"d3-path": "^1.0.9",
"d3-hierarchy": "^1.1.9",
"d3-axis": "^1.0.12",
"d3-quadtree": "^1.0.6",
"d3-time": "^2.1.1"
"d3-quadtree": "^1.0.6"
},
"devDependencies": {
"@hypertrace/test-utils": "^0.0.0"
Expand Down
5 changes: 2 additions & 3 deletions projects/observability/src/shared/components/cartesian/chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { TimeRange } from '@hypertrace/common';
import { TimeInterval } from 'd3-time';
import { LegendPosition } from '../legend/legend.component';
import { ChartTooltipRef } from '../utils/chart-tooltip/chart-tooltip-popover';
import { ChartEvent, ChartEventListener } from './chart-interactivty';
Expand Down Expand Up @@ -126,9 +125,9 @@ export interface Axis {
max?: number;

/**
* Determine the tick count labels (number or time interval)
* Determine the tick count labels
*/
tickCount?: number | TimeInterval;
tickCount?: number;
}

export interface AxisCrosshair {
Expand Down
3 changes: 1 addition & 2 deletions projects/observability/src/shared/components/cartesian/d3/axis/cartesian-axis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Axis as D3Axis, axisBottom, AxisDomain, axisLeft, axisRight, AxisScale, axisTop } from 'd3-axis';
import { BaseType, select, Selection } from 'd3-selection';
import { TimeInterval } from 'd3-time';
import { defaultsDeep } from 'lodash-es';
import { MouseLocationData } from '../../../utils/mouse-tracking/mouse-tracking';
import { SvgUtilService } from '../../../utils/svg/svg-util.service';
Expand Down Expand Up @@ -188,7 +187,7 @@ export class CartesianAxis<TData = {}> {
}
}

private calculateAxisTickCount(): number | TimeInterval {
private calculateAxisTickCount(): number {
if (this.configuration?.tickCount !== undefined) {
return this.configuration.tickCount;
}
Expand Down