feat: button new style #1121
Merged
feat: button new style #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1121 +/- ##
=======================================
Coverage 85.10% 85.10%
=======================================
Files 822 822
Lines 17011 17011
Branches 2158 2158
=======================================
Hits 14478 14478
Misses 2502 2502
Partials 31 31 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -3,6 +3,7 @@ export const enum ButtonRole { | |||
| Primary = 'primary', | |||
| Secondary = 'secondary', | |||
| Tertiary = 'tertiary', | |||
| Quaternary = 'quaternary', | |||
There was a problem hiding this comment.
We might want a different name for this at some point, but I can't come up with anything better right now.
jake-bassett
approved these changes
Sep 14, 2021
| @@ -123,6 +135,10 @@ | |||
| @include button-style(inherit, inherit, $blue-5, $blue-4); | |||
| } | |||
|
|
|||
| &.primary-reversed { | |||
There was a problem hiding this comment.
This line needs to change also.
Unit Test Results 4 files 265 suites 16m 45s ⏱️ Results for commit a99596d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new style: Primary Reversed, being similar to primary but inverting colors.
Testing
Visual Testing
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.