Skip to content

feat: Adding percentage reference to Gauge List #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2021
Merged

feat: Adding percentage reference to Gauge List #1203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion projects/observability/src/shared/components/gauge-list/gauge-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnChanges, Output } from '@angular/core';
import { TypedSimpleChanges } from '@hypertrace/common';
import { maxBy } from 'lodash-es';
import { maxBy, sum } from 'lodash-es';

@Component({
selector: 'ht-gauge-list',
Expand All @@ -25,6 +25,7 @@ import { maxBy } from 'lodash-es';
</div>
<div class="value">
<span>{{ item.value | htDisplayNumber }}</span>
<span *ngIf="this.showPercentages"> ({{ item.percentage | htDisplayNumber }}%)</span>
</div>
</ng-container>
</div>
Expand All @@ -43,6 +44,9 @@ export class GaugeListComponent<T extends GaugeItem = GaugeItem> implements OnCh
@Input()
public showLabels: boolean = true;

@Input()
public showPercentages: boolean = false;

@Input()
public showItemBorders: boolean = true;

Expand Down Expand Up @@ -73,12 +77,14 @@ export class GaugeListComponent<T extends GaugeItem = GaugeItem> implements OnCh
}

const colorLookupMap = this.buildColorLookupForData(this.items);
const totalCount = sum(this.items.map((gaugeItem: GaugeItem) => gaugeItem.value));

this.itemOptions = this.items.map(option => ({
label: option.label,
color: colorLookupMap.get(option.colorKey ?? option.label),
width: `${((option.value / maxValue!) * 100).toFixed(2)}%`,
value: option.value,
percentage: totalCount > 0 ? (option.value / totalCount) * 100 : 100,
original: option
}));
}
Expand All @@ -95,6 +101,7 @@ export class GaugeListComponent<T extends GaugeItem = GaugeItem> implements OnCh
export interface GaugeItem {
label: string;
value: number;
percentage?: number;
colorKey?: string;
}

Expand Down