Skip to content

fix: make explorer content scrollable #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2021
Merged

fix: make explorer content scrollable #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
004ac73
fix: make explorer content scrollable
aaron-steinfeld Nov 10, 2021
a9b1426
Merge branch 'main' into fix-explorer-sizing
aaron-steinfeld Nov 10, 2021
9910ea6
Merge branch 'main' into fix-explorer-sizing
aaron-steinfeld Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions projects/observability/src/pages/explorer/explorer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import 'font';
@import 'layout';

.explorer {
display: flex;
Expand All @@ -11,21 +12,19 @@
}

.explorer-content {
@include scrollable-container(24px);
display: flex;
flex-direction: column;
padding: 24px 24px 0;
flex: 1;
min-height: 0;
}

.explorer-data-toggle {
flex: 0;
padding-bottom: 16px;
padding: 24px 24px 16px;
}

.explorer-filter-bar {
flex: 0;
padding-bottom: 8px;
padding: 0 24px 8px;
}

.panel-title {
Expand All @@ -49,14 +48,9 @@

.results-panel {
flex: 1;
overflow: hidden;

.label {
@include body-1-medium;
}

.results-panel-content {
padding-top: 12px;
}
}
}
27 changes: 13 additions & 14 deletions projects/observability/src/pages/explorer/explorer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,20 @@ import {
template: `
<div class="explorer">
<ht-page-header class="explorer-header"></ht-page-header>
<ht-toggle-group
class="explorer-data-toggle"
[items]="this.contextItems"
[activeItem]="this.activeContextItem$ | async"
(activeItemChange)="this.onContextUpdated($event.value)"
></ht-toggle-group>

<ht-filter-bar
class="explorer-filter-bar"
[attributes]="this.attributes$ | async"
[syncWithUrl]="true"
(filtersChange)="this.onFiltersUpdated($event)"
></ht-filter-bar>
<div class="explorer-content">
<ht-toggle-group
class="explorer-data-toggle"
[items]="this.contextItems"
[activeItem]="this.activeContextItem$ | async"
(activeItemChange)="this.onContextUpdated($event.value)"
></ht-toggle-group>

<ht-filter-bar
class="explorer-filter-bar"
[attributes]="this.attributes$ | async"
[syncWithUrl]="true"
(filtersChange)="this.onFiltersUpdated($event)"
></ht-filter-bar>

<ht-panel class="visualization-panel" [(expanded)]="this.visualizationExpanded">
<ht-panel-header>
<ht-panel-title [expanded]="this.visualizationExpanded"
Expand Down