Skip to content

fix: avoid dupe columns, clear group name from url on none #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021
Merged

fix: avoid dupe columns, clear group name from url on none #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions projects/observability/src/pages/explorer/explorer-dashboard-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,9 +518,26 @@ export class ExplorerDashboardBuilder {
protected getAttributesToExcludeFromUserDisplay(context: ExplorerGeneratedDashboardContext): Set<string> {
switch (context) {
case ObservabilityTraceType.Api:
return new Set(['protocol', 'apiName', 'statusCode', 'duration', 'startTime', 'calls']);
return new Set([
'protocol',
'serviceName',
'apiName',
'statusCode',
'apiTraceErrorSpanCount',
'duration',
'startTime',
'calls'
]);
case SPAN_SCOPE:
return new Set(['protocolName', 'displaySpanName', 'statusCode', 'duration', 'startTime']);
return new Set([
'protocolName',
'serviceName',
'displaySpanName',
'statusCode',
'errorCount',
'duration',
'startTime'
]);
default:
return assertUnreachable(context);
}
Expand Down
7 changes: 6 additions & 1 deletion projects/observability/src/pages/explorer/explorer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,12 @@ export class ExplorerComponent {
private getGroupByQueryParams(groupBy?: GraphQlGroupBy): QueryParamObject {
const key = groupBy?.keys[0];
if (key === undefined) {
return {};
return {
// Clear existing selection
[ExplorerQueryParam.Group]: undefined,
[ExplorerQueryParam.OtherGroup]: undefined,
[ExplorerQueryParam.GroupLimit]: undefined
};
}

return {
Expand Down