Skip to content

feat: exporting field and active tab label change #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2021
Merged

feat: exporting field and active tab label change #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e76b60b
feat: exporting field and active tab label change
anandtiwary Dec 7, 2021
8667a29
refactor: fixing lint errors
anandtiwary Dec 7, 2021
aba8364
Merge branch 'main' into export-field-and-output
anandtiwary Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/observability/src/public-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ export * from './shared/services/entity-breadcrumb/entity-breadcrumb.resolver';
// Span Detail
export { SpanData } from './shared/components/span-detail/span-data';
export { SpanTitle } from './shared/components/span-detail/span-title';
export { SpanDetailTab } from './shared/components/span-detail/span-detail-tab';

export * from './shared/components/span-detail/span-detail.component';
export * from './shared/components/span-detail/span-detail.module';
export { SpanDetailLayoutStyle } from './shared/components/span-detail/span-detail-layout-style';
Expand Down
14 changes: 13 additions & 1 deletion projects/observability/src/shared/components/span-detail/span-detail.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ import { SpanDetailTab } from './span-detail-tab';
<ng-content></ng-content>
</div>

<ht-tab-group class="tabs-group" [activeTabLabel]="this.activeTabLabel">
<ht-tab-group
class="tabs-group"
[activeTabLabel]="this.activeTabLabel"
(activeTabLabelChange)="this.onActiveTabLabelChange($event)"
>
<ht-tab label="${SpanDetailTab.Request}" *ngIf="this.showRequestTab">
<ht-span-request-detail
class="request"
Expand Down Expand Up @@ -69,6 +73,9 @@ export class SpanDetailComponent implements OnChanges {
@Input()
public activeTabLabel?: SpanDetailTab;

@Output()
private readonly activeTabLabelChange: EventEmitter<SpanDetailTab> = new EventEmitter<SpanDetailTab>();

@Output()
public readonly closed: EventEmitter<void> = new EventEmitter<void>();

Expand All @@ -93,4 +100,9 @@ export class SpanDetailComponent implements OnChanges {
this.totalLogEvents = (this.spanData?.logEvents ?? []).length;
}
}

public onActiveTabLabelChange(tabLabel: SpanDetailTab): void {
this.activeTabLabel = tabLabel;
this.activeTabLabelChange.emit(tabLabel);
}
}