Skip to content

fix: setting max-height for multi select options container #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

fix: setting max-height for multi select options container #1315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f481a2
fix: setting max-height for multi select options container
arjunlalb Dec 10, 2021
5e0b593
Merge branch 'main' into multi-select-container-height
arjunlalb Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/components/src/multi-select/multi-select.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
min-width: 120px;
display: flex;
height: 100%;
max-height: 360px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be driven by a component input. 360px might be too less in some cases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, we should make it scroll

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already scrolls.

360px is good for about 10 items. Do we want the consumer to be able to control the height via an input? Currently, it can be done with css override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. I meant we should be able to do it via code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm. don't want to block the pr though

flex-direction: column;

.divider {
Expand Down