Skip to content

feat: Adding state disable to dropdown #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2022
Merged

feat: Adding state disable to dropdown #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b3a082
feat: Adding state disable to dropdown
Jan 21, 2022
73fceb6
Merge branch 'main' into AddSetDisableStateToDropdown
palbizu Jan 24, 2022
acc7486
Merge branch 'main' into AddSetDisableStateToDropdown
palbizu Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/components/src/input/input.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export class InputComponent<T extends string | number> implements ControlValueAc
public registerOnTouched(onTouch: (value: T | undefined) => void): void {
this.propagateControlValueChangeOnTouch = onTouch;
}

public setDisabledState(isDisabled?: boolean): void {
this.disabled = isDisabled ?? false;
}
Expand Down
4 changes: 4 additions & 0 deletions projects/components/src/select/select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,10 @@ export class SelectComponent<V> implements ControlValueAccessor, AfterContentIni
this.propagateControlValueChangeOnTouch = onTouch;
}

public setDisabledState(isDisabled?: boolean): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the property is public is there a need for a method to access it?

Copy link
Contributor Author

@palbizu palbizu Jan 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clear reasons. Probably @anandtiwary can clarify it. I followed the same structure already implemented in the input component to the Control Value Accessor. I will try to find the reason.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is related to ControlValueAccessor interface, this function will be used by reactive form field to set the disabled state using form group itself. We will not pass any [disabled] input in the template while using the select component in the forms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So @itssharmasandeep , does it fine to keep it public?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is fine.

this.disabled = isDisabled ?? false;
}

private propagateValueChangeToFormControl(value: V | undefined): void {
this.propagateControlValueChange?.(value);
this.propagateControlValueChangeOnTouch?.(value);
Expand Down