Skip to content

fix: checkbox on write refresh #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2022
Merged

fix: checkbox on write refresh #1404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2e9ca3
fix: checkbox on write refresh
Jan 31, 2022
958e8f5
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into FixCh…
Jan 31, 2022
04b282e
Merge branch 'main' into FixCheckboxOnWriteRefresh
palbizu Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/components/src/combo-box/combo-box.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ export class ComboBoxComponent<TValue = string> implements AfterViewInit, OnChan

public writeValue(text?: string): void {
this.text = text;
this.changeDetectorRef.markForCheck();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to call setText here? Everything except following

      this.textChange.emit(this.text);
      this.propagateValueChangeToFormControl(this.text);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying setText without markForCheck doesn't update the text

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some function calls from setText still seems relevant whenever text is changed via form control. The emit and propogate method mentioned above would not be required. I will approve the PR, but you can play with it.

}

public registerOnChange(onChange: (value?: string) => void): void {
Expand Down