Skip to content

fix(ui): centered toggle switch vertically #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2022
Merged

fix(ui): centered toggle switch vertically #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e4969c
fix(ui): centered toggle switch vertically
23nobody Feb 5, 2022
e90561f
fix(ui): encapsulated mat-slide-toggle in a div
23nobody Feb 8, 2022
36ec7f0
Merge branch 'main' into toggle-switch-center
23nobody Feb 17, 2022
ff1895f
fix(style): added align-items center property
23nobody Feb 17, 2022
3a6bb8f
fix(code): fixed linting
23nobody Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion projects/components/src/toggle-switch/toggle-switch.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
@import 'color-palette';
@import 'font';

:host {
.toggle-switch {
display: flex;
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No host styling please. Here, it's being used as a scope due to the also-problematic abuse of ng-deep, but we're not applying host styles.

The problem with host styling is that's breaking encapsulation - the parent is responsible for applying styles at the host level, and applying them inside the component can introduce non-obvious conflicts.

Please try to accomplish the same thing with regular css classes inside the component.

Copy link
Contributor Author

@23nobody 23nobody Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encapsulated it inside a div

Copy link
Contributor

@anandtiwary anandtiwary Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to add align-items:center too ?

Copy link
Contributor Author

@23nobody 23nobody Feb 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

align-items: center;

::ng-deep {
.mat-slide-toggle {
&.disabled {
Expand Down
20 changes: 11 additions & 9 deletions projects/components/src/toggle-switch/toggle-switch.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,17 @@ import { ToggleSwitchSize } from './toggle-switch-size';
styleUrls: ['./toggle-switch.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<mat-slide-toggle
color="primary"
[checked]="this.checked"
[ngClass]="{ 'small-slide-toggle': this.size === '${ToggleSwitchSize.Small}', disabled: this.disabled }"
[disabled]="this.disabled"
(change)="this.onToggle($event)"
>
<div class="label">{{ this.label }}</div>
</mat-slide-toggle>
<div class="toggle-switch">
<mat-slide-toggle
color="primary"
[checked]="this.checked"
[ngClass]="{ 'small-slide-toggle': this.size === '${ToggleSwitchSize.Small}', disabled: this.disabled }"
[disabled]="this.disabled"
(change)="this.onToggle($event)"
>
<div class="label">{{ this.label }}</div>
</mat-slide-toggle>
</div>
`
})
export class ToggleSwitchComponent {
Expand Down